-
Notifications
You must be signed in to change notification settings - Fork 298
refs endpoint #978
refs endpoint #978
Conversation
dirkmc
commented
Apr 24, 2019
- make refs endpoint compatible with js-ipfs
- add refs pull stream
- move refs test to interface-js-ipfs-core (see add tests for refs endpoint interface-js-ipfs-core#460)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by comment: refsReadableStream
is missing (ls
and others have ReadableStream
versions)
Missed it or was it left out on purpose?
@lidel I didn't see it used anywhere so I didn't add it. Do you know if it will be needed? FYI I am refactoring this PR heavily to
|
I added |
Thanks! FYSA we always provide both pull-stream and readable-stream versions (see interface-js-ipfs-core/SPEC/FILES), and if streaming is supported users expect to find both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README to include links to the docs in interface-ipfs-core
.
@dirkmc I think this just needs a rebase to get the tests passing - go-ipfs 0.4.20 is broken for adding files so we've reverted to testing against 0.4.19. |
@alanshaw thanks, rebased |