exporter maxDepth #197
exporter maxDepth #197
Conversation
ghost
assigned 
test/exporter.js
Outdated
| ) | ||
| }) | ||
| ) | ||
| }).timeout(30 * 1000) |
There was a problem hiding this comment.
Please put timeouts at the beginning of the test
test/importer.js
Outdated
| @@ -311,7 +311,7 @@ module.exports = (repo) => { | |||
| done() | |||
| }) | |||
| ) | |||
| }) | |||
| }).timeout(60 * 1000) | |||
There was a problem hiding this comment.
Please put timeouts at the beginning of the test
test/importer.js
Outdated
| @@ -331,7 +331,7 @@ module.exports = (repo) => { | |||
| done() | |||
| }) | |||
| ) | |||
| }) | |||
| }).timeout(60 * 1000) | |||
There was a problem hiding this comment.
Please put timeouts at the beginning of the test
| @@ -91,7 +91,7 @@ module.exports = (repo) => { | |||
| expect(nodes[0].path).to.be.eql(expectedHash) | |||
| expect(mh.toB58String(nodes[0].hash)).to.be.eql(expectedHash) | |||
| expect(nodes[1].path).to.be.eql(expectedHash + '/b') | |||
| expect(nodes[1].size).to.be.eql(21) | |||
| expect(nodes[1].size).to.be.eql(29) | |||
There was a problem hiding this comment.
Why does this need to change if the test is the same?
There was a problem hiding this comment.
Had to change this for ls because go-ipfs reports the size as reported by the link, not the what we get from the file.size accessor... Still have to investigate which one is the correct one. Any clues on why these values differ?
There was a problem hiding this comment.
I see, I believe that was added for ipfs.add and it seems it also made it to .ls. LGTM then :)
|
When using this.timeout, you have to change the arrow functions to regular function declarations |
|
Appveyor is failing with a weird permission error. Not sure if critical.. |
In order to be able to efficiently do an
ipfs.files.ls, and for it to be correct, supporting not only dirs but also shardeddirs, the best way IMO is to integrate this into the exporter, introducing an optionalmaxDepthoption.To fully make this happen: