This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
feat: add Dockerfile and Makefile #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable testing in CI Changes required: - Makefile:2 change REGISTRY to an IPFS controlled repository License: MIT Signed-off-by: Andrew Martin <sublimino@gmail.com>
hsanjuan
suggested changes
Jun 18, 2018
| @@ -0,0 +1,19 @@ | |||
| FROM instrumentisto/dep:0.4.1 AS builder | |||
There was a problem hiding this comment.
better use official golang Go images. That way someone reading this dockerfile doesn't have to go figure out what instrumentisto images do. The build process is simple enough to be able to use a vanilla approach.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable testing in CI
Changes required: