Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #13

Merged
merged 5 commits into from
Apr 3, 2018
Merged

Setup CI #13

merged 5 commits into from
Apr 3, 2018

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Mar 31, 2018

No description provided.

@magik6k magik6k force-pushed the fix/jenkinsfile branch 2 times, most recently from 23eb104 to 97b8c98 Compare April 3, 2018 20:23
@magik6k
Copy link
Collaborator Author

magik6k commented Apr 3, 2018

So this sort of works and the rendered page shows up in checks \o/.

Note: had to eject create-react-app to change some paths and work around multiformats/js-cid#38.

https://ipfs.io/ipfs/Qmd2CNGet18dy9bwB91pk3zCe5KQp96SDh56NFtVWZboxf/

2 issues I see:

  • There seem to be some missing styles.
  • It should use # router.

@dirkmc mind having a look?

@dirkmc
Copy link
Collaborator

dirkmc commented Apr 3, 2018

I think this should fix the styles issue: #15

@dirkmc
Copy link
Collaborator

dirkmc commented Apr 3, 2018

@magik6k are you sure it needs the # router? Seems to work ok without it

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 3, 2018

@magik6k are you sure it needs the # router? Seems to work ok without it

It does, but it results in links like https://ipfs.io/repo/z8mWaFhNutrvGaKNcybtLjgLMEC3n5tC5 which don't work. What we'd need is some way to setup routing on ipfs side (there are some proposals such as 404 file and scripted unixfs)

@dirkmc
Copy link
Collaborator

dirkmc commented Apr 3, 2018

Ah I see what you mean, I'll take a look

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 3, 2018

Merging as it does what it sohuld do

@magik6k magik6k merged commit 652fb9c into master Apr 3, 2018
@magik6k magik6k deleted the fix/jenkinsfile branch April 4, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants