Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't seem to redirect CIDv1 #275

Closed
djdv opened this issue Sep 4, 2017 · 2 comments · Fixed by #281
Closed

Doesn't seem to redirect CIDv1 #275

djdv opened this issue Sep 4, 2017 · 2 comments · Fixed by #281
Assignees
@lidel
Labels
status/blocked/upstream-bug Blocked by upstream bugs

Comments

@djdv
Copy link

djdv commented Sep 4, 2017

Using version 2.0.0alpha7

Only the first hash(CIDv0) is anchored and redirected, the other 2(CIDv1) are not, sometimes the other hashes are anchored but only if they're not the first hash and not broken with a line, they're never redirected though.
ipfs add hello.txt
/ipfs/QmcTkUnEKwnnodaCRSVFpFEJTMJNcFfU64cD6s3BxfbWvf
ipfs add --cid-version=1 hello.txt
/ipfs/zb2rhkWWWwy77qJ1n4ghAnFktRkJT66psfWqGjvQ3bc3W2U8r
ipfs add --chunker=rabin --cid-version=1 --hash=Blake2b-256 hello.txt
/ipfs/zCT5htke6LPUaHfrtDJkv15EekGG8xnY3eHE52ZbnBphinybqchC

/ipfs/zCT5htke6LPUaHfrtDJkv15EekGG8xnY3eHE52ZbnBphinybqchC
^not anchored
/ipfs/QmcTkUnEKwnnodaCRSVFpFEJTMJNcFfU64cD6s3BxfbWvf
/ipfs/zCT5htke6LPUaHfrtDJkv15EekGG8xnY3eHE52ZbnBphinybqchC
^anchored

companion-addon-bug01
@lidel lidel mentioned this issue Sep 4, 2017
Closed
@lidel
Copy link
Member

lidel commented Sep 4, 2017

Thank you for reporting this!

IPFS resources are detected byis-ipfs library, which seems to be lacking support for CIDv1.
I created ipfs-shipyard/is-ipfs#12 to address that.

Let's keep this issue open until the upstream fix is released.

@lidel lidel self-assigned this Sep 4, 2017
@lidel lidel added the status/blocked/upstream-bug Blocked by upstream bugs label Sep 4, 2017
@lidel lidel changed the title Doesn't seem to redirect CIDs Doesn't seem to redirect CIDv1 Sep 4, 2017
@lidel lidel mentioned this issue Sep 10, 2017
Merged
lidel added a commit that referenced this issue Sep 12, 2017
@lidel
feat: add CID support
c11dfa5 
Includes CID tests from ipfs-shipyard/is-ipfs#12
Partially solves #275
lidel added a commit that referenced this issue Sep 12, 2017
@lidel
fix: linkify text nodes without whitespace padding
de724c1 
Closes #275
@lidel lidel mentioned this issue Sep 12, 2017
Merged
lidel added a commit that referenced this issue Sep 12, 2017
@lidel
feat: add CID support
3b5ed39 
Includes CID tests from ipfs-shipyard/is-ipfs#12
Partially solves #275
lidel added a commit that referenced this issue Sep 12, 2017
@lidel
fix: linkify text nodes without whitespace padding
fa673ea 
Closes #275
@lidel
Copy link
Member

lidel commented Sep 12, 2017 •
edited
Loading

@djdv I've just published above fixes to Developer Channel as v2.0.9beta1, give it a try! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
status/blocked/upstream-bug Blocked by upstream bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CID Support ipfs/ipfs-companion
2 participants
@lidel @djdv