Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CIDv1 #12

Closed
lidel opened this issue Sep 4, 2017 · 3 comments · Fixed by #13
Closed

Support for CIDv1 #12

lidel opened this issue Sep 4, 2017 · 3 comments · Fixed by #13
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Sep 4, 2017

As noted in ipfs/ipfs-companion#275, is-ipfs v0.3.0 is unaware of CIDv1.

References:
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Sep 4, 2017
@lidel lidel mentioned this issue Sep 4, 2017
Closed
@daviddias
Copy link
Member

@fbaiodias wanna move this to the IPFS org so that more folks can help maintain it?

@fbaiodias
Copy link
Contributor

@diasdavid done https://github.com/ipfs/is-ipfs/ 😃

lidel added a commit to lidel/is-ipfs that referenced this issue Sep 10, 2017
@lidel
feat: CID Support
c66bb64 
Closes ipfs-shipyard#12
@lidel lidel mentioned this issue Sep 10, 2017
Merged
@lidel
Copy link
Member Author

lidel commented Sep 10, 2017 •
edited
Loading

Guys, please check if #13 looks okay.
If it does, we need a new release of is-ipfs with it 🌵

lidel added a commit to ipfs/ipfs-companion that referenced this issue Sep 12, 2017
@lidel
feat: add CID support
c11dfa5 
Includes CID tests from ipfs-shipyard/is-ipfs#12
Partially solves #275
lidel added a commit to ipfs/ipfs-companion that referenced this issue Sep 12, 2017
@lidel
feat: add CID support
3b5ed39 
Includes CID tests from ipfs-shipyard/is-ipfs#12
Partially solves #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: CID Support lidel/is-ipfs
3 participants
@lidel @daviddias @fbaiodias