Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden CSS to be OS-agnostic #329

Closed
lidel opened this issue Dec 9, 2017 · 0 comments · Fixed by #336
Closed

Harden CSS to be OS-agnostic #329

lidel opened this issue Dec 9, 2017 · 0 comments · Fixed by #336
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Dec 9, 2017

Some people prefer to use dark theme in their OS.

These themes usually invert the default CSS definitions of "black text on white background" and break sites that do not explicitly specify background and font colours. Our popup page is one of them.

We should add defensive CSS that explicitly define text and background colours.

Examples

Done with v2.1.1beta4 and random dark GTK themes under Linux.

2017-12-09-150621_860x1421_scrot
2017-12-09-150648_860x1421_scrot
2017-12-09-150719_860x1421_scrot
@lidel lidel added kind/bug A bug in existing code (including security flaws) good first issue Good issue for new contributors help wanted Seeking public contribution on this issue UX labels Dec 9, 2017
olizilla added a commit to tableflip/ipfs-companion that referenced this issue Dec 13, 2017
@olizilla
fix: ipfs#329 - Add explicit color styles
8f7b96c
@olizilla olizilla mentioned this issue Dec 13, 2017
Merged
lidel added a commit that referenced this issue Dec 13, 2017
@lidel
Merge pull request #336 from tableflip/fix/reduce-menu-jank
86e77b3 
Fixes menu jank under Brave and closes #329 ✨
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reduce menu render jank tableflip/ipfs-companion
1 participant
@lidel