fix: reduce menu render jank #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser menu rendering in brave is super janky. This PR in-lines width and overflow styles to the body element of the menu page so the browser has a clue as early as possible how wide the menu will be. Brave renders a scroll bar on the menu by default, so we disable that too.
The height of our menu changes, which can also causes some render jank, so it'd be worth considering marking menu items as visually disabled rather then pulling them out of the menu when not available.
Also adds explicit color styles to hopefully fix #329 though I've not been able to test it.