Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce menu render jank #336

Merged
merged 3 commits into from
Dec 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion add-on/src/popup/browser-action/gateway-status.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = function gatewayStatus ({
}) {
const api = ipfsNodeType === 'embedded' ? 'js-ipfs' : ipfsApiUrl
return html`
<ul class="list mv3 ph3">
<ul class="list mv3 ph3 bg-white black">
<li class="flex mb2">
<span class="w-40 f7 ttu">${browser.i18n.getMessage('panel_statusGatewayAddress')}</span>
<code class="w-60 f7 tr">${gatewayAddress == null ? 'unknown' : gatewayAddress}</code>
Expand Down
2 changes: 1 addition & 1 deletion add-on/src/popup/browser-action/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8">
<meta name="viewport" content="width=device-width" />
</head>
<body>
<body style="width: 320px; overflow: hidden; background: white;">
<div id="root"></div>
<script src="../../ipfs-companion-common.js"></script>
<script src="browser-action.js"></script>
Expand Down
2 changes: 1 addition & 1 deletion add-on/src/popup/browser-action/nav-item.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const html = require('choo/html')

function navItem ({ icon, text, bold, disabled, onClick }) {
let className = 'button-reset db w-100 bg-white bg-near-white--hover b--none outline-0--focus pointer pv2 ph3 f5 tl'
let className = 'button-reset db w-100 black bg-white bg-near-white--hover b--none outline-0--focus pointer pv2 ph3 f5 tl'
if (bold) className += ' b'

return html`
Expand Down
2 changes: 1 addition & 1 deletion add-on/src/popup/browser-action/page.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module.exports = function browserActionPage (state, emit) {
const gwStatusProps = Object.assign({}, state)

return html`
<div class="helvetica" style="min-width: 320px">
<div class="helvetica">
${header(headerProps)}
${contextActions(contextActionsProps)}
${operations(opsProps)}
Expand Down