-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: share.ipfs.io is powered by Helia #138
Conversation
feat: remove react bundle
deployed to https://share.sgtpooki.com in order to test some flow outside of my network |
it's also deployed automatically from the branch for this PR now at https://autumn-river-1012.on.fleek.co |
consolidate publish logic for download & upload flows
src/hooks/useFiles.ts
Outdated
pending: true, | ||
published: false | ||
} | ||
dispatch({ type: 'add_start', ...file }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did the add_start event move down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it down because I updated the fileProvider to use the same publishing logic, and use CIDs for the files property on the fileProvider state. So instead of Record<string, FileState>
with a shortid
it's now Record<CID.toString(), FileState>
, and add_start was triggering publish logic before we had the CID (with add_success
).
Since this is all in the browser now (not using RPC calls to a kubo node) we don't need to do add_start
and add_success
.. I need to change these to upload_start and upload_success or similar, and probably add another property on the filesProvider for filesToUpload
to separate them from the files
Record
This reverts commit f7da4ed.
fixes #136
TODO
await mfs.stat('/')
infetchShareLink
. this only occurs when adding a file to share.. and only occurs in firefox