Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: share.ipfs.io is powered by Helia #138

Merged
merged 58 commits into from
Oct 8, 2024
Merged

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 18, 2024

  • feat!: removing react-scripts and old cruft
  • feat: vite dev progress
  • feat: replace ipfs-core with Helia
  • feat: remove react-scripts
  • feat: add files/folders with Helia
  • feat: publish provider record for file CIDs
  • chore: ignore dist folder
  • fix: footer UI update
  • feat: libp2p devtools & file downloading
  • chore: documenting work to be done

fixes #136

TODO

  • address all todos
  • Fix i18n loading on download page (it tries to register to quick and fails...? idk whats up)
  • fix downloading a file: i.e. https://share.sgtpooki.com/#/QmcyyLvDzCrduuvGVUQEh1DzFvM7UWGfc9sUg87PjjYCw7 , when downloading the image, and trying to open it.. it's not valid
  • Fix bug with FireFox on await mfs.stat('/') in fetchShareLink. this only occurs when adding a file to share.. and only occurs in firefox
  • Fix CID not appearing in DHT on check.ipfs.network when adding and publishing files
  • Fix download page for a directory. When we get the "its a directory" we should have enough information to list the files
  • Fix QR code not scannable on iphone
  • Update all filenames to use kebab-case

@SgtPooki
Copy link
Member Author

deployed to https://share.sgtpooki.com in order to test some flow outside of my network

@SgtPooki
Copy link
Member Author

it's also deployed automatically from the branch for this PR now at https://autumn-river-1012.on.fleek.co

consolidate publish logic for download & upload flows
pending: true,
published: false
}
dispatch({ type: 'add_start', ...file })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did the add_start event move down?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it down because I updated the fileProvider to use the same publishing logic, and use CIDs for the files property on the fileProvider state. So instead of Record<string, FileState> with a shortid it's now Record<CID.toString(), FileState>, and add_start was triggering publish logic before we had the CID (with add_success).

Since this is all in the browser now (not using RPC calls to a kubo node) we don't need to do add_start and add_success.. I need to change these to upload_start and upload_success or similar, and probably add another property on the filesProvider for filesToUpload to separate them from the files Record

@SgtPooki SgtPooki marked this pull request as ready for review October 8, 2024 19:06
@SgtPooki SgtPooki merged commit 37d5478 into main Oct 8, 2024
2 checks passed
@SgtPooki SgtPooki deleted the feat/update-share-ipfs-io branch October 8, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strip down to the full-featured browser (Helia) usecase
3 participants