Handle IPNS names without dots #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking if an ipfs name is blocked, we may get an
`/ipns/{dnslink_name}` where the `{dnslink_name}` has been
encoded according to
https://specs.ipfs.tech/http-gateways/subdomain-gateway/#host-request-header
That is, "." has been replaced with "-" and "-" has been replaced with "--".
Because of this, when the given dns name has no dots, we undo things are
replace "--" with "-" and "-" with ".".
hsanjuan
force-pushed
the
handle-encoded-dnslink
branch
from
8a38dac
to
5433362
Compare
|
This is manually proven to work as expected now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if an ipfs name is blocked, we may get an
/ipns/{dnslink_name}where the{dnslink_name}has been encoded according tohttps://specs.ipfs.tech/http-gateways/subdomain-gateway/#host-request-header
That is, "." has been replaced with "-" and "-" has been replaced with "--".
Because of this, when the given dns name has no dots, we undo things are replace "--" with "-" and "-" with ".".