Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale frontend elements #35

Closed
4 tasks done
parkan opened this issue Nov 17, 2018 · 13 comments
Closed
4 tasks done

Remove stale frontend elements #35

parkan opened this issue Nov 17, 2018 · 13 comments
Assignees

Comments

@parkan
Copy link
Contributor

parkan commented Nov 17, 2018

A lot of the peerpad.net site components have become stale, were never implemented, or aren't well-aligned with the immediate goal of using the tool for internal notetaking. Let's cull those so we can focus on the core product:

  • Landing Page: the landing page clearly had a lot of work put into it, but it's out of date (still talks about Y.js), doesn't bring much value to internal users, and creates an extra step before you get your pad. Other *pad products tend to only deploy a landing page of any kind of if they want you to pay or log in, otherwise booting to a new document is common (this can be prefilled with some explanatory copy, e.g. https://dillinger.io/). Let's bypass this page during internal testing and come back to it fresh afterwards.
  • "PeerPad is Alpha" banner: important warning but well-understood by internal users (and kind of demoralizing), let's make it dismissable
  • Files/Settings/Shortcuts: never implemented, can hide until and unless we build them out
  • "Math Pad" mode: I guess this was meant to be a different editor UI (maybe like LaTeX/overleaf?) but never seems to have been implemented. Removing the mode choice also makes booting directly to a document unambiguous.

Most of these are just deletions in react templates or otherwise simple work, probably a couple of hours at the most. I know a lot of work has gone into the original prototype version, but it is no longer well-aligned with our immediate goals for the product.

Completing them will clear the path to #25, which will provide us with invaluable user feedback to inform further UX work, and a cleaner base for new designs on (#31).

@parkan
Copy link
Contributor Author

parkan commented Nov 17, 2018

instead of the landing page, it might be useful to have a simple "about" page linked from the footer that explains that this is no ordinary pad (could just be a link to a blog post, too)

@jimpick
Copy link

jimpick commented Nov 17, 2018

I agree that it would be good to simplify it a bit... especially if the primary target for now is just internal users.

I know we do want to keep it open for public users to also serve as a demo for peer-star-app. That's probably the biggest challenge for the messaging on the site. Should we be trying to funnel developers to IPFS / peer-star-app? Or should the messaging be more consumer-focused?

@parkan
Copy link
Contributor Author

parkan commented Nov 19, 2018

my view is that we should dial in performance and core UX before trying to convert external users

it's fine for the app to be publicly accessible for the curious developer, so any messaging should focus on that (though, again, I'm in favor of keeping it relatively minimal)

@victorb
Copy link
Member

victorb commented Nov 28, 2018

One option could be to leave peerpad.net as-is right now (production branch in the GitHub repository) and exclusively work from master branch. Master branch gets deployed to dev.peerpad.net, and there is where we can streamline it (open directly to new pad, remove verbose warnings and similar)

@victorb
Copy link
Member

victorb commented Nov 29, 2018

PR here: peer-base/peer-pad#238

@victorb
Copy link
Member

victorb commented Nov 29, 2018

PR is currently waiting review. In the meantime, you can review the new versions UI here: https://ipfs.io/ipfs/QmWMDrh8yHuyqhFYUvH4BJ27pKBbCUuKYzpP3KgRAH1QQV/ < checks all the boxes in the opening issue here

@victorb
Copy link
Member

victorb commented Nov 30, 2018

The PR has been merged now and the changes mentioned in this issue have been deployed to js.peerpad.net! Unfortunately, something is wrong with the certificates on that site, working on fixing that.

I'd like to have confirmation on the following:

One option could be to leave peerpad.net as-is right now (production branch in the GitHub repository) and exclusively work from master branch. Master branch gets deployed to dev.peerpad.net, and there is where we can streamline it (open directly to new pad, remove verbose warnings and similar)

^ would mean that for internal testing, we tell people to use dev.peerpad.net instead, and we leave peerpad.net in it's current state, for visitors to understand peerpad before using it.

@parkan
Copy link
Contributor Author

parkan commented Nov 30, 2018

do we have any analytics on the live site? I'm curious if it gets a meaningful amount of non-PL usage

@parkan
Copy link
Contributor Author

parkan commented Nov 30, 2018

The PR has been merged now and the changes mentioned in this issue have been deployed to js.peerpad.net! Unfortunately, something is wrong with the certificates on that site, working on fixing that.

js.peerpad.net doesn't seem to be running a web server, do you mean dev.peerpad.net?

would be nice to have a shorter redirect url for this, do we have an internal shortlinker?

I'd like to have confirmation on the following:
...
^ would mean that for internal testing, we tell people to use dev.peerpad.net instead, and we leave peerpad.net in it's current state, for visitors to understand peerpad before using it.

how about this: we can tag f29acedbb76ddca1f208df5fad7257a9c1585311 as "production" and leave it deployed on the main site with the explainer landing page, etc

I don't think it's worth maintaining it as an active branch/backporting work from master on an ongoing basis, unless we see significant usage (or a really bad vulnerability)

@victorb
Copy link
Member

victorb commented Nov 30, 2018

@parkan Ah, yes, I meant dev.peerpad.net. Don't think it's long enough to warrant a shorter link...

My suggestion is to leave the production as-is today, which means being locked to commit peer-base/peer-pad@2727041

Agree with not worth backporting fixes unless we see high impact security issues.

@parkan
Copy link
Contributor Author

parkan commented Nov 30, 2018

oops, you're right, I had the wrong parent, 2727041 is right

reasoning for shortlink (or more unique prefix) is to minimize keystrokes to load the site, there's probably a lot of dev... prefixes in most people's histories

not a huge deal tho! marking this as done

@parkan parkan closed this as completed Nov 30, 2018
@victorb
Copy link
Member

victorb commented Nov 30, 2018

Yeah, my fear about link shorteners is that eventually they die, and all the redirects die with them. Usually just better to use the proper link directly. We can add aliases to test.peerpad.net or whatever in the future.

Missed this question before:

do we have any analytics on the live site? I'm curious if it gets a meaningful amount of non-PL usage

AFAIK, we don't. We do have Rollbar but that only gives us the errors.

Once the pinner has metrics, we can get some basic information from that, first total peers and total collaborations, in the future we can expand it to contain more information.

@parkan
Copy link
Contributor Author

parkan commented Dec 3, 2018

sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants