Skip to content

Commit

Permalink
chore: final fixes for getting sourcemap support (#232) (#233)
Browse files Browse the repository at this point in the history
License: MIT
Signed-off-by: Victor Bjelkholm <git@victor.earth>
  • Loading branch information
Pedro Teixeira authored Nov 16, 2018
1 parent dd66cae commit 2727041
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions config/webpack.config.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ module.exports = {
// see: https://github.com/webpack-contrib/uglifyjs-webpack-plugin#options
cache: true,
parallel: true,
sourceMap: shouldUseSourceMap,

// see: https://github.com/mishoo/UglifyJS2/tree/harmony#minify-options
uglifyOptions: {
Expand Down Expand Up @@ -272,7 +273,6 @@ module.exports = {
// https://github.com/facebookincubator/create-react-app/issues/2488
ascii_only: true,
},
sourceMap: shouldUseSourceMap,
}
}),
// Note: this won't work without ExtractTextPlugin.extract(..) in `loaders`.
Expand Down Expand Up @@ -324,7 +324,7 @@ module.exports = {
new RollbarSourceMapPlugin({
accessToken: process.env.ROLLBAR_ACCESS_TOKEN || 'non-existing',
version: process.env.GIT_COMMIT,
publicPath: publicPath,
publicPath: 'https://peerpad.net',
ignoreErrors: true
})
],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"leadMaintainer": "Jacob Heun <jacobheun@gmail.com>",
"scripts": {
"start": "node scripts/start.js",
"build": "GIT_COMMIT=$(git rev-parse HEAD) PUBLIC_URL='./' node scripts/build.js",
"build": "GENERATE_SOURCEMAP=true GIT_COMMIT=$(git rev-parse HEAD) PUBLIC_URL='./' node scripts/build.js",
"lint": "standard 'src/**/*.js' 'test/**/*.js'",
"test": "jest --no-cache --env=jsdom",
"test:e2e": "jest --testMatch **/test/e2e/**/*.js",
Expand Down

0 comments on commit 2727041

Please sign in to comment.