Restart transfer after transmitter off #70
Conversation
| // Find a reasonable target address to respond to by either using our radio_address | ||
| // or using the sender_addr if no radio address is set | ||
| let target_addr = if let Some(radio_address) = &self.radio_address { | ||
| radio_address.to_owned() |
There was a problem hiding this comment.
Sorry for still being on basic questions - under what cases is radio_address Some vs. None?
There was a problem hiding this comment.
I see - it's a passthrough of a configuration point, and None means I didn't write it in my config file.
So if someone asks me to transmit a thing, I'll always send it to the configured point if one is configured, but if not I'll send it to the address that asked for it to be sent?
I think that makes sense. But don't a lot of these requests have a target address as a parameter? Does that take priority?
There was a problem hiding this comment.
You are right that many of the requests do take a target address as a parameter. The radio address is mainly there to support responses to requests which don't take a target address, but in reality (for this specific demo) it is generally the correct address to send responses to.
The main caveat here is when using the controller and when the radio_address is set...but both in actual testing and local testing we've had access to the myceli logs, which has allowed us access to any response information that was needed.
Changed
ResumeTransmitDagto start with requesting missing blocks from current window. Also addresses the scenario where the transmitter has restarted or has no session for the dag by iterating through windows to find the latest window with missing blocks.