Skip to content

Commit

Permalink
feat: move tsc linter rules to eslint (#1513)
Browse files Browse the repository at this point in the history
- Resolves #1459
- Since all relevant typescript linter rules are now incorporated in the latest eslint-config-ipfs, we can drop them from our tsconfig.

---------

Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
  • Loading branch information
wemeetagain and SgtPooki committed Jul 29, 2024
1 parent 9a8e31b commit f78c9ac
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
5 changes: 0 additions & 5 deletions src/config/tsconfig.aegir.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
// module resolution
"esModuleInterop": true,
"moduleResolution": "node",
// linter checks
"noImplicitReturns": false,
"noFallthroughCasesInSwitch": true,
"noUnusedLocals": true,
"noUnusedParameters": false,
// advanced
"verbatimModuleSyntax": true,
"forceConsistentCasingInFileNames": true,
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/dependency-check/fail-unused/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
/* eslint-disable no-unused-vars */
// @ts-expect-error unused
import { execa } from 'execa'
1 change: 0 additions & 1 deletion test/fixtures/dependency-check/ts-fail/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
// @ts-expect-error unused
import { execa } from 'execa'
import './other.js'
1 change: 0 additions & 1 deletion test/fixtures/dependency-check/ts-pass/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
// @ts-expect-error unused
import { execa } from 'execa'

0 comments on commit f78c9ac

Please sign in to comment.