Remove pre-push hooks

[daviddias]

Everyone gets frustrated using it and most folks just skip it anyways. We now have fast CI so it should be good to remove.

[vmx]

I still find it useful. I would rather disable it on a per-project basis.

[daviddias]

Or rather opt-in than opt-out

[victorb]

I think the frustration comes from that it takes forever to run. For example, when working on js-multiaddr as the entire suite (node, browser and webworker) takes less than five seconds for me. But on ipfs/js-ipfs it takes 10 minutes to run through the entire thing, so usually I skip it.

Having it be opt-in rather than opt-out sounds like a acceptable compromise though.

[vmx]

Isn't it opt-in already? If you have a pre-push section in your package.json, then it is run. Else it's not.

[vmx]

I was wrong. Even without a pre-push section it's running something. I'm happy to look into how to make this opt-in before we remove it completely.

[victorb]

@vmx afaik, doing the following steps will make my pushes for a project run pre-push stuff before:

git clone $js-ipfs-git-url
cd js-ipfs
yarn
git commit --allow-empty --message "Hello"
git push origin master

Which is opt-out (I need to remove ./.git/hooks/pre-push) rather than opt-in.

[vmx]

I tried locally the first package that felt sensible. git-validate seems to do exactly what I'd expect. If there is no pre-push section, it does nothing. If there is one (compatible to what we have today), it runs those scripts.

So I propose switching to git-validate and removing pre-push from the projects that don't want to have it. They could even just remove the test and leave the lint in.

[jacobheun]

#244 introduced a small npm install bug, ipfs/js-ipfs#1444 (comment)