Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messed-up variables #180

Merged
merged 1 commit into from
Dec 10, 2017
Merged

Fix messed-up variables #180

merged 1 commit into from
Dec 10, 2017

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Dec 10, 2017

For some reason, Uglify is messing up with some variables on js-ipfs. Here's a quick fix.

This closes ipfs/js-ipfs#1131

@ghost ghost assigned hacdias Dec 10, 2017
@ghost ghost added the status/in-progress In progress label Dec 10, 2017
@hacdias hacdias changed the title Update browser.js Fix messed-up variables Dec 10, 2017
@hacdias hacdias requested a review from daviddias December 10, 2017 19:37
@daviddias
Copy link
Member

Thanks @hacdias!

@daviddias daviddias merged commit 17a28a6 into master Dec 10, 2017
@ghost ghost removed the status/in-progress In progress label Dec 10, 2017
@daviddias daviddias deleted the fix-incorrect-vars branch December 10, 2017 19:39
@codecov
Copy link

codecov bot commented Dec 10, 2017

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   77.37%   77.37%           
=======================================
  Files           6        6           
  Lines         137      137           
=======================================
  Hits          106      106           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c056f...5ffffe8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught Error: Can't set property: 'links' is immutable
2 participants