Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing/http/client: allow custom User-Agent #17

Closed
2 tasks done
lidel opened this issue Dec 9, 2022 · 0 comments · Fixed by #31
Closed
2 tasks done

routing/http/client: allow custom User-Agent #17

lidel opened this issue Dec 9, 2022 · 0 comments · Fixed by #31
Assignees
@lidel
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Dec 9, 2022 •
edited
Loading

Currently, routing/http/client sends requests with generic User-Agent: Go-http-client/1.1 from golang's http package.

Before we ship with Kubo 0.18, this library should:

  • Change implicit default to own User-Agent: go-libipfs/routing/http/client[/version]
  • Allow Kubo for passing own version string via func WithUserAgent(ua string) option
    • We want IPNI at cid.contact to know which versions of Kubo are sending requests, to make informed decision about supporting legacy endpoints, making breaking changes etc. (cc @willscott)
@lidel lidel added the need/triage Needs initial labeling and prioritization label Dec 9, 2022
@ipfs ipfs deleted a comment from welcome bot Dec 9, 2022
lidel added a commit that referenced this issue Jan 14, 2023
@lidel
feat(routing/http/client): allow custom User-Agent
c9e692f 
Closes #17
@lidel lidel mentioned this issue Jan 14, 2023
Merged
lidel added a commit to ipfs/kubo that referenced this issue Jan 14, 2023
@lidel
fix: User-Agent sent to HTTP routers
296869b 
See ipfs/boxo#17
and ipfs/boxo#31
@lidel lidel mentioned this issue Jan 14, 2023
Merged
2 tasks
lidel added a commit to ipfs/kubo that referenced this issue Jan 14, 2023
@lidel
fix: User-Agent sent to HTTP routers
28b92f0 
See ipfs/boxo#17
and ipfs/boxo#31
@lidel lidel self-assigned this Jan 14, 2023
@lidel lidel added P1 High: Likely tackled by core team if no one steps up effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed need/triage Needs initial labeling and prioritization labels Jan 14, 2023
@lidel lidel closed this as completed in #31 Jan 17, 2023
lidel added a commit that referenced this issue Jan 17, 2023
@lidel
feat(routing/http/client): allow custom User-Agent (#31)
442a269 
Closes #17
lidel added a commit to ipfs/kubo that referenced this issue Jan 17, 2023
@lidel
fix: User-Agent sent to HTTP routers
2909955 
See ipfs/boxo#17
and ipfs/boxo#31
@lidel lidel mentioned this issue Jan 17, 2023
Closed
lidel added a commit to ipfs/kubo that referenced this issue Jan 18, 2023
@lidel
fix: User-Agent sent to HTTP routers
9088989 
See ipfs/boxo#17
and ipfs/boxo#31
lidel added a commit to ipfs/kubo that referenced this issue Jan 18, 2023
@lidel
fix: User-Agent sent to HTTP routers
da625cd 
See ipfs/boxo#17
and ipfs/boxo#31
lidel added a commit to ipfs/kubo that referenced this issue Jan 18, 2023
@lidel
fix: User-Agent sent to HTTP routers
1fa3a78 
See ipfs/boxo#17
and ipfs/boxo#31
galargh pushed a commit to ipfs/kubo that referenced this issue Jan 23, 2023
@lidel @galargh
fix: User-Agent sent to HTTP routers
7bcca5f 
See ipfs/boxo#17
and ipfs/boxo#31
hannahhoward pushed a commit to filecoin-project/kubo-api-client that referenced this issue Jun 19, 2023
@lidel
fix: User-Agent sent to HTTP routers
11e7b86 
See ipfs/boxo#17
and ipfs/boxo#31
hannahhoward pushed a commit to filecoin-project/kubo-api-client that referenced this issue Jun 19, 2023
@lidel @galargh
fix: User-Agent sent to HTTP routers
21016f1 
See ipfs/boxo#17
and ipfs/boxo#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(routing/http/client): allow custom User-Agent ipfs/boxo
1 participant
@lidel