Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap/server/internal/decision: fix: remove unused private type #179

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Feb 17, 2023

No description provided.

@Jorropo Jorropo requested a review from a team as a code owner February 17, 2023 17:24
@Jorropo Jorropo enabled auto-merge (rebase) February 17, 2023 17:24
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #179 (4d2e289) into main (8c31910) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   29.33%   29.37%   +0.03%     
==========================================
  Files         100       99       -1     
  Lines       11103    11089      -14     
==========================================
  Hits         3257     3257              
+ Misses       7487     7473      -14     
  Partials      359      359              

@Jorropo
Copy link
Contributor Author

Jorropo commented Feb 17, 2023

0s
Upload coverage to Codecov
Run codecov/codecov-action@81cd2dc8148241f03f5839d295e000b8f761e378
==> linux OS detected
https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
Error: Codecov: Error validating uploader: Signed digest did not match

Whatever, transiant issues unrealted to this.

@Jorropo Jorropo enabled auto-merge (rebase) February 17, 2023 17:36
@Jorropo Jorropo merged commit c394290 into main Feb 17, 2023
@Jorropo Jorropo deleted the fix-ci branch February 17, 2023 17:37
@galargh
Copy link
Contributor

galargh commented Feb 21, 2023

@guseggert @Jorropo Unified CI comes with automatic Go version upgrades, see #159 Hence, the note at the top of the files modified here: https://github.com/ipfs/go-libipfs/blob/main/.github/workflows/go-test.yml#L1-L2 We'll try to make it more obvious ahead of the next Go version upgrade - we're thinking of using reusable workflows in hope it'll make it clearer that the true workflow definition lives elsewhere.

Would you be able to get to #159? It's currently held up on go-check failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants