Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename migration tool to boxo-migrate, tidy up, and add docs #243

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Rename migration tool to boxo-migrate, tidy up, and add docs #243

merged 2 commits into from
Mar 31, 2023
+74 −8

Conversation

guseggert
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #243 (aafa1d3) into main (92407c6) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   47.88%   47.93%   +0.04%     
==========================================
  Files         269      269              
  Lines       32976    32976              
==========================================
+ Hits        15792    15806      +14     
+ Misses      15513    15502      -11     
+ Partials     1671     1668       -3

see 9 files with indirect coverage changes

@guseggert guseggert force-pushed the feat/boxo-migrate branch 5 times, most recently from d6eaf95 to dd9cee0 Compare March 30, 2023 21:18
@guseggert guseggert force-pushed the feat/boxo-migrate branch 2 times, most recently from aa8edae to bb808e3 Compare March 31, 2023 00:20
@guseggert guseggert marked this pull request as ready for review March 31, 2023 00:35
@guseggert guseggert requested a review from a team as a code owner March 31, 2023 00:35
@guseggert guseggert self-assigned this Mar 31, 2023
This was referenced Mar 31, 2023
Closed
Closed
@guseggert guseggert changed the title feat: rename migrate -> boxo-migrate, add extra pointers to output Rename migration tool to boxo-migrate, tidy up, and add docs Mar 31, 2023
BigLep
BigLep reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good to me - thanks

@guseggert guseggert requested a review from Jorropo March 31, 2023 12:42
Jorropo
Jorropo approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll submit a PR that complains if it does not find a .git in a current or parent folder.

@guseggert guseggert enabled auto-merge (rebase) March 31, 2023 14:19
@guseggert guseggert merged commit d04755c into main Mar 31, 2023
@guseggert guseggert deleted the feat/boxo-migrate branch March 31, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigLep BigLep BigLep left review comments

@Jorropo Jorropo Jorropo approved these changes

Assignees

@guseggert guseggert

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guseggert @BigLep @Jorropo