refactor(gateway): consistent tracing names #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
gateway/consistent-metrics
branch
from
7b67660
to
c76cb01
Compare
hacdias
changed the title
Codecov Report
@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 47.89% 47.85% -0.04%
==========================================
Files 273 273
Lines 33186 33186
==========================================
- Hits 15893 15880 -13
- Misses 15616 15624 +8
- Partials 1677 1682 +5
|
lidel
reviewed
Apr 5, 2023
There was a problem hiding this comment.
@hacdias do you have a screenshot how it looks like in Jaeger UI when traced in Kubo or bifrost-gateway (whichever is easier for you)?
See https://github.com/ipfs/kubo/blob/master/docs/environment-variables.md#how-to-use-jaeger-ui
(examples in #233, just want to eyeball it so we are happy with how it looks)
hacdias
force-pushed
the
gateway/consistent-metrics
branch
from
c76cb01
to
8e43931
Compare
|
@lidel here it is. I re-added the |
hacdias
force-pushed
the
gateway/consistent-metrics
branch
from
8e43931
to
85d963b
Compare
lidel
force-pushed
the
gateway/consistent-metrics
branch
from
85d963b
to
1a5f5ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of ipfs-inactive/bifrost-gateway#68, I decided to make the tracing names more consistent. When we moved the gateway to boxo, and then on #176, we added and changed some of the tracings, but they were not consistent.
What I did here:
Handler.to all handler tracings, similar to what we had on theIPFSBackendwithIPFSBackend..boxo/gatewayto clearly indicate the sub-packageand stopped pre-pending.Gateway.in the tracing name, since we already have the gateway part in the tracer name.