Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gateway): switch to xxhash/v2 #285

Merged
merged 2 commits into from
Apr 27, 2023
Merged

refactor(gateway): switch to xxhash/v2 #285

merged 2 commits into from
Apr 27, 2023

Conversation

hsanjuan
Copy link
Contributor

This is related to ipfs/kubo#9839.

boxo still depends on badger, which still requires xxhash/v1, but at least doesn't require it xxhash/v1 itself directly anymore.

This is related to ipfs/kubo#9839.

boxo still depends on badger, which still requires xxhash/v1, but at least doesn't require it xxhash/v1 itself directly anymore.
@hsanjuan hsanjuan requested review from lidel, hacdias and a team as code owners April 26, 2023 12:59
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #285 (f1f2105) into main (b3b6620) will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   47.94%   47.06%   -0.89%     
==========================================
  Files         273      270       -3     
  Lines       33186    33115      -71     
==========================================
- Hits        15912    15586     -326     
- Misses      15600    15851     +251     
- Partials     1674     1678       +4     
Impacted Files Coverage Δ
gateway/assets/assets.go 75.75% <ø> (ø)
gateway/handler_ipns_record.go 0.00% <ø> (ø)

... and 18 files with indirect coverage changes

@lidel lidel changed the title Switch to xxhash/v2 refactor: switch to xxhash/v2 Apr 27, 2023
@lidel lidel changed the title refactor: switch to xxhash/v2 refactor(gateway): switch to xxhash/v2 Apr 27, 2023
@lidel lidel merged commit 268cad8 into main Apr 27, 2023
@lidel lidel deleted the remove-xxhash-v1 branch April 27, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants