-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reusable ipns verify #292
Conversation
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 48.03% 47.87% -0.16%
==========================================
Files 279 280 +1
Lines 33439 33521 +82
==========================================
- Hits 16062 16048 -14
- Misses 15697 15786 +89
- Partials 1680 1687 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is reasonable. This package will likely be refactored at some point in the near future when the lean records get more attention: ipfs/specs#376
Small ask: can we change the following lines to use UnmarshalIpnsEntry
?
boxo/gateway/handler_ipns_record.go
Lines 53 to 54 in 8059f18
var record ipns_pb.IpnsEntry | |
err = proto.Unmarshal(rawRecord, &record) |
a96c24f
to
1922e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I stated previously, I think this is a reasonable change. It will likely be refactored until the end of the year, but it's good to keep this functionality together.
This makes sense but I am suprised that this is being merged with 0 coverage in |
@Jorropo indeed, I was thinking of reverting this. |
@laurentsenta I merged this too impulsively, reverted in #293. I only realised how coupled all the names were to Kubo's
|
Sister PR in kubo: ipfs/kubo#9867
Extracts the ipns verification code out of kubo to boxo. This makes the verification code reusable, for example, with gateway-conformance testing (ipfs/gateway-conformance#37)
Relates to ipfs/specs#376