New very fast unixfs implementation. #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can download single block raw leaves files over car.
I first meant it to be used for unixfs correctness checking, however later I've implemented it for range requests. This make it fail at both, so let's keep correctness, I'll implement range requests later.
This fixes bug introduced in 4707f58. This is was completely wrong (does not load the digest and incorrectly truncate the data incorrectly.)
Jorropo
force-pushed
the
unixfs
branch
2 times, most recently
from
4b123c2
to
234debc
Compare
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 66.41% 65.13% -1.29%
==========================================
Files 207 211 +4
Lines 24692 26194 +1502
==========================================
+ Hits 16400 17062 +662
- Misses 6866 7590 +724
- Partials 1426 1542 +116
|
Jorropo
force-pushed
the
unixfs
branch
3 times, most recently
from
b56b758
to
c7b9772
Compare
```
$ benchstat /mnt/ramdisk/{old,new}
name old time/op new time/op delta
PB-12 730ns ± 5% 255ns ± 2% -65.04% (p=0.000 n=9+10)
name old alloc/op new alloc/op delta
PB-12 224B ± 0% 0B -100.00% (p=0.000 n=10+10)
name old allocs/op new allocs/op delta
PB-12 4.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10)
```
Closed
This needs: - Use boxo for types and helpers - Tests
Node is the easy to use API, don't confuse peoples with aliasable CIDs.
This used to be buggy because defer would be called in the loop.
We stopped checking roots, this only provides slightly better error messages when getting unknown car versions. Remove dependency on cbor for this very small value.
This would make the code tricky to read and I'm not sure it would help in a significant way.
Jorropo
force-pushed
the
unixfs
branch
2 times, most recently
from
7f0f457
to
5b77262
Compare
|
Will release this in a new repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ipfs/go-cid#159.
DagPB + Unixfsparsing withgogoprotois~1500nshere it is~250ns.I'll do
boxo/ipld/unixfsvsgo-unixfsnodevsboxo/unixfsdecoding in the future.