gateway: add WithContextHint to handler and implement it on BlocksBackend
#550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAttention:
@@ Coverage Diff @@
## 01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_ #550 +/- ##
=======================================================================================================
- Coverage 65.56% 65.50% -0.07%
=======================================================================================================
Files 207 207
Lines 25606 25612 +6
=======================================================================================================
- Hits 16788 16776 -12
- Misses 7345 7359 +14
- Partials 1473 1477 +4
|
hacdias
force-pushed
the
01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_
branch
from
6c590b8 to
39f6a56
Compare
…ksBackend` This allows the `BlocksBackend` to inject a session in the context, it remove the problems where we keep reseting the bitswap session each time we call the `fetcher`.
Jorropo
force-pushed
the
01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_
branch
from
39f6a56 to
8109917
Compare
Jorropo
force-pushed
the
01-12-gateway_add_WithContextHint_to_handler_and_implement_it_on_BlocksBackend_
branch
from
20035c9 to
992c55c
Compare
hacdias
approved these changes
Jan 12, 2024
Jorropo
changed the base branch from
01-12-blockservice_add_NewSessionContext_and_EmbedSessionInContext_
to
main
Jorropo
deleted the
01-12-gateway_add_WithContextHint_to_handler_and_implement_it_on_BlocksBackend_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
BlocksBackendto inject a session in the context, it remove the problems where we keep reseting the bitswap session each time we call thefetcher.