-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway: tests for simpler superfluous namespace handling #572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 65.48% 65.60% +0.12%
==========================================
Files 207 207
Lines 25605 25597 -8
==========================================
+ Hits 16768 16794 +26
+ Misses 7361 7324 -37
- Partials 1476 1479 +3
|
I did not look too deep, but I think this breaks valid content paths like Not sure how feasible, but it may be easier to move handleSuperfluousNamespace check from very front of the request processign pipeline, to very end: trigger it on "not found" code path (e.g. the place where we look for |
a99d5dc
to
19304bf
Compare
@lidel it seems that we tested this in Kubo too. See here: ipfs/kubo#10322 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you for cleaning this up!
Closes #344. See comments below.
Kubo: ipfs/kubo#10322