Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: remote blocks backend #594

Merged
merged 4 commits into from
Apr 9, 2024
Merged

gateway: remote blocks backend #594

merged 4 commits into from
Apr 9, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 25, 2024

Partially addresses #576: moves all remote blocks stuff to the gateway package, as well as the remote value store we used in the examples. It also includes the cached blockstore as well as the cached dns.

Moving the graph/CAR backend will be more complicated and involved. I will leave that for a separate PR.

@hacdias hacdias changed the title Gateway remote blocks gateway: remote blocks backend Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 160 lines in your changes are missing coverage. Please review.

Project coverage is 59.98%. Comparing base (fd005f3) to head (4715a54).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   60.61%   59.98%   -0.63%     
==========================================
  Files         232      230       -2     
  Lines       27788    22196    -5592     
==========================================
- Hits        16843    13315    -3528     
+ Misses       9467     7407    -2060     
+ Partials     1478     1474       -4     
Files Coverage Δ
examples/gateway/proxy/main.go 0.00% <0.00%> (ø)
gateway/value_store.go 0.00% <0.00%> (ø)
gateway/remote_blocks_backend.go 0.00% <0.00%> (ø)
gateway/blockstore.go 0.00% <0.00%> (ø)

... and 188 files with indirect coverage changes

@hacdias hacdias self-assigned this Mar 25, 2024
@hacdias hacdias marked this pull request as ready for review March 25, 2024 15:06
@hacdias hacdias requested review from lidel and a team as code owners March 25, 2024 15:06
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, small nits below

CHANGELOG.md Outdated Show resolved Hide resolved
gateway/dns.go Outdated Show resolved Hide resolved
gateway/remote_blocks_backend.go Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (squash) April 9, 2024 13:57
@hacdias hacdias merged commit 63c3ec6 into main Apr 9, 2024
14 checks passed
@hacdias hacdias deleted the gateway-remote-blocks branch April 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants