fix(routing): return 404 when no record is found #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
routing-404-no-records
branch
from
eae07ae
to
64094bb
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage ? 59.47%
=======================================
Files ? 233
Lines ? 28294
Branches ? 0
=======================================
Hits ? 16829
Misses ? 9992
Partials ? 1473
|
lidel
approved these changes
Apr 12, 2024
hacdias
force-pushed
the
routing-404-no-records
branch
from
64094bb
to
dbe3e8e
Compare
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ipfs/someguy#58.
Sets 404 if the router returns
routing.ErrNotFoundor if the list of providers is empty.