Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to not read size of blocks for want-have requests #672

Merged
merged 10 commits into from
Sep 27, 2024

Improving option name and make consistent

639ef65
Select commit
Loading
Failed to load commit list.
Merged

feat: option to not read size of blocks for want-have requests #672

Improving option name and make consistent
639ef65
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 0s

60.18% (-0.01%) compared to 171b0b7

View this Pull Request on Codecov

60.18% (-0.01%) compared to 171b0b7

Details

Codecov Report

Attention: Patch coverage is 73.91304% with 24 lines in your changes missing coverage. Please review.

Project coverage is 60.18%. Comparing base (171b0b7) to head (639ef65).

Files with missing lines Patch % Lines
...swap/server/internal/decision/blockstoremanager.go 64.51% 8 Missing and 3 partials ⚠️
bitswap/server/server.go 0.00% 7 Missing ⚠️
bitswap/server/internal/decision/engine.go 92.30% 3 Missing and 1 partial ⚠️
bitswap/options.go 0.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   60.18%   60.18%   -0.01%     
==========================================
  Files         241      241              
  Lines       30707    30771      +64     
==========================================
+ Hits        18482    18519      +37     
- Misses      10574    10596      +22     
- Partials     1651     1656       +5     
Files with missing lines Coverage Δ
bitswap/options.go 36.36% <0.00%> (-1.74%) ⬇️
bitswap/server/internal/decision/engine.go 91.44% <92.30%> (-0.35%) ⬇️
bitswap/server/server.go 63.92% <0.00%> (-0.72%) ⬇️
...swap/server/internal/decision/blockstoremanager.go 85.33% <64.51%> (-5.43%) ⬇️

... and 7 files with indirect coverage changes