Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: config rule is preventing upgrade of @typescript-eslint/eslint-plugin from 5.62.0 to 7.5.0 #217

Closed
SgtPooki opened this issue Apr 3, 2024 · 2 comments · Fixed by #218
Labels

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Apr 3, 2024

see https://github.com/ipfs/aegir/actions/runs/8521375637/job/23339383672?pr=1492#step:5:11

& #211

@SgtPooki
Copy link
Member Author

SgtPooki commented Apr 3, 2024

updating all deps results in :

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: eslint-config-ipfs@6.0.1
npm ERR! Found: @typescript-eslint/eslint-plugin@7.5.0
npm ERR! node_modules/@typescript-eslint/eslint-plugin
npm ERR!   @typescript-eslint/eslint-plugin@"^7.5.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/eslint-plugin@"^5.52.0" from eslint-config-standard-with-typescript@37.0.0
npm ERR! node_modules/eslint-config-standard-with-typescript
npm ERR!   eslint-config-standard-with-typescript@"^37.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/sgtpooki/.npm/_logs/2024-04-03T01_19_59_735Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/sgtpooki/.npm/_logs/2024-04-03T01_19_59_735Z-debug-0.log

and https://www.npmjs.com/package/eslint-config-standard-with-typescript says it's deprecated and to use https://www.npmjs.com/package/eslint-config-love

SgtPooki added a commit that referenced this issue Apr 3, 2024
achingbrain added a commit that referenced this issue May 1, 2024
…ith eslint-config-love (#218)

Fixes #217

BREAKING CHANGE: eslint-config-love requires updated peer dependencies

---------

Co-authored-by: achingbrain <alex@achingbrain.net>
github-actions bot pushed a commit that referenced this issue May 1, 2024
## [7.0.0](v6.0.2...v7.0.0) (2024-05-01)

### ⚠ BREAKING CHANGES

* eslint-config-love requires updated peer dependencies

### Dependencies

* upgrade deps, replace eslint-config-standard-with-typescript with eslint-config-love ([#218](#218)) ([a83be5b](a83be5b)), closes [#217](#217)
Copy link

github-actions bot commented May 1, 2024

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant