fix: use @typescript-eslint/no-unused-vars #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
May 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2024
## [6.0.2](v6.0.1...v6.0.2) (2024-05-01) ### Bug Fixes * use @typescript-eslint/no-unused-vars ([#221](#221)) ([9a95776](9a95776)), closes [/github.com/standard/eslint-config-standard/blob/master/src/index.ts#L143](https://github.com/ipfs//github.com/standard/eslint-config-standard/blob/master/src/index.ts/issues/L143) ### Trivial Changes * Update .github/workflows/stale.yml [skip ci] ([1f9ebc6](1f9ebc6))
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aegir currently relies on typescript to perform two linter rules, which is annoying for reasons mentioned in the above issue.
noFallthroughCasesInSwitchnoUnusedLocalsThis PR makes typescript rules more strict to enforce both of these conditions.
For
noFallthroughCasesInSwitch, it appears that thestandardeslint rule set already includes theno-fallthroughrule.So this PR only needs to enforce
noUnusedLocal, and we just add@typescript-eslint/no-unused-vars.