-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use eslint env instead of individual globals #4
Conversation
Setting the value to `false` means it is not writable
Depends on: - [ ] ipfs/eslint-config-ipfs#4 BREAKING CHANGE: ipfs-repo dep update requires an database migration to v10
Depends on: - [ ] ipfs/eslint-config-ipfs#4 BREAKING CHANGE: ipfs-repo dep update requires an database migration to v10
maybe its better to set env instead of this https://eslint.org/docs/user-guide/configuring.html#specifying-environments also for globals (https://eslint.org/docs/user-guide/configuring.html#specifying-globals) it should be |
I tried setting the env, it thinks |
is Blob and others also undefined or its just globalThis? with env browser ? |
I can make it happy with: env: {
es2020: true, // for globalThis
browser: true, // for Blob
node: true
}, |
Setting |
seems better, what do you think ? we can remove the globals all together, we already have |
Depends on: - [ ] ipfs/eslint-config-ipfs#4 BREAKING CHANGE: ipfs-repo dep update requires an database migration to v10
Depends on: - [ ] ipfs/eslint-config-ipfs#4 BREAKING CHANGE: ipfs-repo dep update requires an database migration to v10
Setting the value to
false
means it is not writable