resolve homedir #106
Merged
resolve homedir #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Jun 19, 2020
| func encodeBlock(dst, src []byte) (d int) |
There was a problem hiding this comment.
Ah, these are vendored deps. We should just leave them alone.
There was a problem hiding this comment.
so just remove the go fmt commit? Can do, although it means go fmt ./... is always going to cause problems in this repo
There was a problem hiding this comment.
Yeah. Unfortunately, our vendoring game here could use some work.
main.go
Outdated
| return ipfspath, nil | ||
| expandedPath, err := homedir.Expand(ipfspath) | ||
| if err != nil { | ||
| return "", nil |
There was a problem hiding this comment.
no error? This seems like an error.
There was a problem hiding this comment.
fixed. Although question, is it safe/smart to be using homedir this vendored way homedir "github.com/ipfs/fs-repo-migrations/ipfs-2-to-3/Godeps/_workspace/src/github.com/mitchellh/go-homedir"?
aschmahmann
force-pushed
the
fix/resolve-homedir
branch
from
ee4f100 to
10bfc70
Compare
Stebalien
approved these changes
Sep 29, 2020
aschmahmann
force-pushed
the
fix/resolve-homedir
branch
from
10bfc70 to
7f295d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While go-ipfs will resolve
~/myipfspathintouserHomeDir/myipfspathfs-repo-migrations would not. This PR adds resolving~into the users' home directory.Review by commit, since this PR includes some overdue
go fmtchanges as well.