Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Concurrent map access in Entry.SesTrk #73

Closed
Stebalien opened this issue Feb 19, 2019 · 2 comments · Fixed by #74
Closed

Concurrent map access in Entry.SesTrk #73

Stebalien opened this issue Feb 19, 2019 · 2 comments · Fixed by #74
Assignees
@hannahhoward
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

This happens because we send shared *Entry objects to each message queue but each message queue then goes and modifies the associated sessions.

IMO, the correct fix is to decouple state tracking from these entries.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Feb 19, 2019
@hannahhoward
Copy link
Contributor

Yes I'm working on a fix for this in the next PR. Hopefully it will become more clear then.

@hannahhoward hannahhoward mentioned this issue Feb 20, 2019
Merged
@ghost ghost assigned hannahhoward Feb 20, 2019
@ghost ghost added the status/in-progress In progress label Feb 20, 2019
@Stebalien Stebalien mentioned this issue Feb 20, 2019
Closed
@hannahhoward
Copy link
Contributor

@Stebalien does #74 look like a good fix for this? Note that it builds on the previous PR (#72) and I feel a bit awkward making this many major changes so close to a release. I can work on a smaller fix if you like.

@ghost ghost removed the status/in-progress In progress label Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hannahhoward hannahhoward

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More specific wantlists ipfs/go-bitswap
2 participants
@Stebalien @hannahhoward