This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
963a926
to
fd268cd
Compare
Stebalien
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm starting to think that the MessageQueue
should be session-ignorant but I'm not sure how to do that and we can tackle it later.
At this point, we should be able to pass |
8dd1682
to
434e0f4
Compare
1a12448
to
eb192a0
Compare
eb192a0
to
60371f7
Compare
|
60371f7
to
b51c20e
Compare
Stebalien
reviewed
Feb 20, 2019
messagequeue/messagequeue.go
Outdated
network MessageNetwork | ||
wl *wantlist.ThreadSafe | ||
refcnt int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra field.
Seperate want list into differentiated types - session tracking and regular fix #13
put trash field only where it is needed, in peer request queues
b51c20e
to
95f6e62
Compare
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…ntList More specific wantlists This commit was moved from ipfs/go-bitswap@ab7ddf0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Make handling of wantlists more clear, avoid memory copying with session tracking, remove unneeded mutexes
Implementation
Currently, the wantlist code obscures multiple different concerns:
All of this is made worse by the fact that every field on a wantlist entry becomes a field on a Bitswap message entry, even though they are unused
This PR takes the following approach:
For Discussion