This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
reduce allocations #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Oct 4, 2018
Stebalien
commented
- Change the protobuf code generation to reduce allocations. We get a lot of wantlists.
- Avoid allocating task keys.
1. Use a `taskEntryKey` *type* instead of a string (now that both peer IDs and CIDs are hashable). 2. Get rid of all uses of `cid.KeyString` (mostly just for type safety). This also means we don't need to parse the CID and allocate to convert it *back* from a string.
This was showing up as a major source of heap allocations (well, at least when the DHT is in client-only mode).
ghost
assigned 
|
This is a starting point. We may also want to use a few pools (e.g., for tasks) but we can see what hotspots are left after merging this. |
Wantlist/Blocks *copy*.
|
(this isn't going to break anything so I'm going to merge and revert later if we decide this isn't something we want to do) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.