This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix: wait until we finish connecting before we cancel the context #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an interesting bug because changes to the DHT have suddenly started triggering it. I'm not sure _why_ we weren't hitting it before now. We may have been ignoring a context somewhere?
dirkmc
approved these changes
Dec 5, 2019
|
@dirkmc Can you think of a good way to test for this internally? We have a test in go-ipfs, but it would be good do have one here as well. |
|
Can you point me to the test in go-ipfs? |
This was referenced Jan 17, 2020
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
fix: wait until we finish connecting before we cancel the context This commit was moved from ipfs/go-bitswap@95b0d81
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interesting bug because changes to the DHT have suddenly started triggering it. I'm not sure why we weren't hitting it before now.
We may have been ignoring a context somewhere?