This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
feat(Benchmarks): Add real world dup blocks test #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Build a benchmark that can replicate the problems that #8 has with LS-ing Wikipedia
Implementation
peers based on using NextWaitTime on passed delay
delay
encounter bitswaping with a long lived session and a large swarm of
peers with real world latency distributions (that causes [WIP] Work towards improving the duplicate blocks issue #8 not to
function well in practice)
For Discussion
The goal here is to have a good benchmark to compare against as we continue to develop improvements to bitswap.
One thing not addressed here are transfer speeds (though you can think of latency in this test as really being time to first byte -- i.e. traditional latency -- + download time). Is that worth addressing seperately.
Benchmarks with results posted in comment.
child of ipfs/kubo#5723