This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Feat/bandwidth limited tests #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hannahhoward
force-pushed
the
feat/bandwidth-limited-tests
branch
2 times, most recently
from
7f0b951
to
33d1de2
Compare
hannahhoward
changed the base branch from
master
to
bugs/stabilize-test-suite
|
due to issues with test suite rebased on to bug fixed branch and this is PR'd against that for now. |
hannahhoward
force-pushed
the
feat/bandwidth-limited-tests
branch
from
33d1de2
to
9383abb
Compare
make both performance benchmarks write to a tmp dir and put in the .gitignore
Limits connection bandwidth in real world benchmarks so that blocks are delayed if single peer is overused fix #40
hannahhoward
force-pushed
the
feat/bandwidth-limited-tests
branch
from
9383abb
to
fe0a253
Compare
hannahhoward
changed the base branch from
bugs/stabilize-test-suite
to
master
Stebalien
approved these changes
Dec 19, 2018
testnet/virtual.go
Outdated
|
|
||
| type rateLimiter interface { | ||
| Limit(dataSize int) time.Duration | ||
| } |
There was a problem hiding this comment.
Yeah, that type should be exported: libp2p/go-libp2p#507. If you want, you can update go-libp2p to 6.0.30 to pull this in.
Updated Libp2p and used it's newly exposed RateLimiter public interface
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…d-tests Feat/bandwidth limited tests This commit was moved from ipfs/go-bitswap@18c401d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Existing benchmarks do not take into account bandwidth limitations on a peer. IOW, assuming all peers have all blocks for a benchmark, the perfect result can be obtained by just continuing to ask the single fastest peer for blocks.
Implementation