This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Avoid allocating for wantlist entries #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allocate a _lot_ of these.
Each one is about 4 words wide (two for the CID, one for the priority, one for the trash flag).
ghost
assigned 
|
Makes sense. I have to admit I am a bit inexperienced with pass by value and slices in go, so I'm not sure I'd catch every potential error in reviewing this. |
|
Personally, I pass by value for anything that's "plain old data" and reasonably small. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably a drop in the bucket but we allocate quite a few of these so we might as well make this as efficient as possible.