-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed for --cid-base
option in go-ipfs (simplified vesion)
#10
Conversation
@Stebalien when gx publishing this should it I use |
6574799
to
41275b6
Compare
--cid-base
option in go-ipfs (simplified vesion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but it would be really nice to get some tests, especially for --filter
in cid-fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as @magik6k. LGTM but needs tests.
c3c6f67
to
d22951b
Compare
--cid-base
option in go-ipfs (simplified vesion)--cid-base
option in go-ipfs (simplified vesion)
Okay I added tests and this should be good to go. Will merge once I get an approving review. |
Can you enable CI here? Should be as simple as |
0b919f0
to
5fac29c
Compare
Someone with the write permissions will need to activate Jenkins and Travis... |
I've activated travis. Not sure how to activate Jenkins. |
(I assume this was OK to merge... If not, we can revert it) |
No, not really, the commits to activate the CI's where untested and I was waiting for them to be activated before I merged this PR. If that did not happen I would of removed the commit from the P.R. to do it separately. In fact the Travis CI need some fixing. Reverting will just make this messier I will create another P.R. |
Just give |
@Stebalien This needs to be gx-published. Should we bump the minor version or just the patch level? I would think minor since it adds a new package. |
In the interest of pushing ipfs/kubo#5789 forward, I want ahead and gx published this as a minor release. |
Either way, just don't bump to version 1.0. For packages <= 1.0, I usually only bump the minor for breaking changes but that's mostly a habit from working with rust/js packages (https://nodesource.com/blog/semver-tilde-and-caret/#caretmajorzero). |
Simplified version of #8
Do not merge until ipfs/kubo#5789 is approved.