fix the keytransform datastore's query implementation #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/ktds
branch
2 times, most recently
from
05e6f03
to
cd09572
Compare
Motivation: I want to be able to use the concrete type from a different package but I can't. This: 1. Exports the concrete datastore type and avoids returning private types from public functions. 2. Removes the mostly useless ktds interface. Unfortunately, it collides with the idiomatic name for the datastore itself. This could break something referencing the `ktds.Datastore` type but nothing is doing that.
The namespace Datastore shouldn't have to touch the mess with the query. Note: this _also_ correctly applies ordering, filters, etc. to the transformed keys (in both the namespaced and the key transform datastores).
magik6k
reviewed
Apr 18, 2019
| case dsq.OrderByKey, *dsq.OrderByKey, | ||
| dsq.OrderByKeyDescending, *dsq.OrderByKeyDescending: | ||
| if orderPreserving { | ||
| child.Orders = child.Orders[:i+1] |
There was a problem hiding this comment.
I feel like I'm missing something here. Why drop other orders here?
There was a problem hiding this comment.
We sort hierarchically. That is, when comparing two entries, we compare with the first "order", then the second order if equal, then the third order if still equal, etc. Given that keys are unique, "order by key" will never return "equal" so there's no point in applying further orders.
There was a problem hiding this comment.
I've added a comment and improved the test coverage more to get codecov to stop complaining.
magik6k
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace Datastore shouldn't have to touch the mess with the query. It was also only partially implementing the query logic, passing through filters, etc. without applying the key transform.
Also adds some tests.