Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mount): don't give up on error #146

Merged
merged 1 commit into from
Mar 28, 2020
Merged

feat(mount): don't give up on error #146

merged 1 commit into from
Mar 28, 2020

Commits on Feb 11, 2020

  1. feat(mount): don't give up on error

    Instead of giving up when a single datastore fails, operate on all datastores
    first. That way:
    
    * If one datastore doesn't support disk usage, we can at least return our best
      estimate for the ones that do.
    * If one datastore fails to sync, we won't fail to sync the others.
    * If one datastore refuses to close, we'll close the others.
    
    Etc.
    
    Also:
    
    * Drop xerrors. We already need go 1.13 elsewhere.
    * Use uber's multierr. It's much simpler than hashicorps (and is already a
      dependency through zap, fx, etc.).
    Stebalien committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    ae47316 View commit details
    Browse the repository at this point in the history