Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context to interfaces #181

Merged
merged 1 commit into from
Oct 27, 2021
Merged

feat: add context to interfaces #181

merged 1 commit into from
Oct 27, 2021

Commits on Oct 27, 2021

  1. feat: add context to interfaces

    This adds contexts to all the Datastore interfaces. The motivation for
    this change is for instrumentation, not cancellation, although these
    can certainly be used in the future for adding cancellation. We
    default to adding context to everything, even if we don't immediately
    use it, because we might need them in the future and making this
    change again is quite painful due to the large number of repos this
    fans out to.
    
    Note that we have not added context to Close() methods, due to it
    being surprising given that it breaks the io.Closer interface, and
    many Close() methods are quick and don't do much work.
    
    This also disables the fuzz test, because it has a submodule which
    transitively depends on this module, so it will fail to build until
    this change is plumbed through go-ds-flatfs.
    guseggert committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    5b1a067 View commit details
    Browse the repository at this point in the history