Improve behaviour on Commits and irretrievable heads #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes some minor changes to improve behaviour when shutting down an application. In this case, perhaps recently broadcasted heads become irretrievable, or perhaps we attempt to broadcast things with a cancelled context. So: - First: do not mark the datastore as dirty when a broadcasted head cannot be fetched. - Second: do not broadcast a head when the context that it was committed with is Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some minor changes to improve behaviour when shutting down an
application. In this case, perhaps recently broadcasted heads become
irretrievable, or perhaps we attempt to broadcast things with a cancelled
context. So:
fetched.