Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"go get -u github.com/ipfs/go-ds-leveldb" fails with error "cannot use d (type *accessor) as type datastore.Datastore in argument to datastore.GetBackedSize" #24

Closed
miguelmota opened this issue Jan 28, 2019 · 3 comments · Fixed by ipfs/go-datastore#113 or ipfs/go-datastore#115
Closed

"go get -u github.com/ipfs/go-ds-leveldb" fails with error "cannot use d (type *accessor) as type datastore.Datastore in argument to datastore.GetBackedSize" #24

miguelmota opened this issue Jan 28, 2019 · 3 comments · Fixed by ipfs/go-datastore#113 or ipfs/go-datastore#115
Assignees
@Stebalien

Comments

@miguelmota
Copy link

miguelmota commented Jan 28, 2019 •
edited
Loading 

$ go get -u github.com/ipfs/go-ds-leveldb
# github.com/ipfs/go-ds-leveldb
../../../../pkg/mod/github.com/ipfs/go-ds-leveldb@v1.2.1/datastore.go:99:25: cannot use d (type *accessor) as type datastore.Datastore in argument to datastore.GetBackedSize:
        *accessor does not implement datastore.Datastore (missing Close method)
../../../../pkg/mod/github.com/ipfs/go-ds-leveldb@v1.2.1/datastore.go:306:32: cannot use transaction literal (type *transaction) as type datastore.Txn in return argument:
        *transaction does not implement datastore.Txn (missing Close method)
$ go version
go version go1.11.5 darwin/amd64
@Stebalien Stebalien mentioned this issue Jan 29, 2019
Merged
@ghost ghost assigned Stebalien Jan 29, 2019
@ghost ghost added the status/in-progress In progress label Jan 29, 2019
@ghost ghost removed the status/in-progress In progress label Jan 29, 2019
@Stebalien
Copy link
Member

Fixed. One of our interfaces leaked into another.

@remilmichael
Copy link

Still showing the same error.

@Stebalien Stebalien reopened this Jan 31, 2019
Stebalien added a commit to ipfs/go-datastore that referenced this issue Jan 31, 2019
@Stebalien
interfaces: make GetBacked* take a Read instead of a Datastore
cd8d7b4 
fixes ipfs/go-ds-leveldb#24
@Stebalien Stebalien mentioned this issue Jan 31, 2019
Merged
@ghost ghost added the status/in-progress In progress label Jan 31, 2019
@ghost ghost removed the status/in-progress In progress label Jan 31, 2019
@Stebalien
Copy link
Member

Ok, so I actually checked this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@miguelmota @Stebalien @remilmichael