Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement GetSize #18

Merged
merged 1 commit into from
Oct 5, 2018
Merged

implement GetSize #18

merged 1 commit into from
Oct 5, 2018

Conversation

Stebalien
Copy link
Member

(also remove outdated comment, all values are []byte now)

@ghost ghost assigned Stebalien Oct 4, 2018
@ghost ghost added the status/in-progress In progress label Oct 4, 2018
@Stebalien Stebalien mentioned this pull request Oct 4, 2018
Merged
kevina
kevina approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@kevina kevina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I double checked and there doesn't seam to be a better way with leveldb.

@Stebalien Stebalien merged commit b545be6 into master Oct 5, 2018
@ghost ghost removed the status/in-progress In progress label Oct 5, 2018
@Stebalien Stebalien deleted the feat/get-size branch October 5, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevina kevina kevina approved these changes

@magik6k magik6k magik6k approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @kevina @magik6k