Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to go-ipfs v0.8.0-rc1 #146

Merged
merged 7 commits into from
Feb 19, 2021
Merged

bump to go-ipfs v0.8.0-rc1 #146

merged 7 commits into from
Feb 19, 2021

Conversation

MichaelMure
Copy link
Collaborator

No description provided.

@MichaelMure
Copy link
Collaborator Author

@Stebalien I suspect I need to change the ci-go version but I don't have access to that repo. Could you give me a hand?

@MichaelMure MichaelMure requested review from Stebalien and Kubuxu and removed request for Stebalien January 21, 2021 17:07
@Stebalien
Copy link
Member

I have published 0.3.0 of the ci-go orb. Please update to that.

@@ -16,7 +16,7 @@ jobs:
test-plugin:
executor:
name: ci-go/default
tag: 1.14.4
tag: 1.15.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. this should have worked.

@MichaelMure
Copy link
Collaborator Author

@Stebalien I updated ci-go, it's now broken in a new way 👍

@Stebalien
Copy link
Member

Ok... 0.3.1 should fix that.

@MichaelMure
Copy link
Collaborator Author

Back to square two :(

@MichaelMure
Copy link
Collaborator Author

@Stebalien a bit more help?

@Stebalien
Copy link
Member

The aws sdk pulls in a newer version of sys. I'll make a PR against go-ipfs.

Stebalien added a commit to ipfs/kubo that referenced this pull request Feb 12, 2021
* Update some go libraries to pull in bug fixes. This will fix the s3
  plugin. See ipfs/go-ds-s3#146.
* Update other libraries for more bug fixes.

This is intentionally minimal as I'm filing it against the release
branch.
@Stebalien Stebalien mentioned this pull request Feb 12, 2021
aschmahmann added a commit to ipfs/kubo that referenced this pull request Feb 18, 2021
* Update some go libraries to pull in bug fixes. This will fix the s3
  plugin. See ipfs/go-ds-s3#146.
* Update other libraries for more bug fixes.

This is intentionally minimal as I'm filing it against the release
branch.
@Stebalien Stebalien merged commit e21b6fe into master Feb 19, 2021
@Stebalien Stebalien deleted the go-ipfs-0.8.0-rc1 branch February 19, 2021 05:36
@Stebalien
Copy link
Member

Well, I got it to work eventually. And surprisingly, I still hate go plugins!

@ianopolous
Copy link
Member

Thank you!

hannahhoward pushed a commit to filecoin-project/kubo-api-client that referenced this pull request Jun 19, 2023
* Update some go libraries to pull in bug fixes. This will fix the s3
  plugin. See ipfs/go-ds-s3#146.
* Update other libraries for more bug fixes.

This is intentionally minimal as I'm filing it against the release
branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants