Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

feat: plumb through context changes #56

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

guseggert
Copy link
Contributor

No description provided.

@guseggert guseggert changed the base branch from master to release-v0 November 18, 2021 19:18
@@ -3,13 +3,13 @@ module github.com/ipfs/go-filestore
go 1.12

require (
github.com/gogo/protobuf v1.3.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI these are upgraded by go mod tidy (it upgrades protobuf, go-cid, go-blockformat)

fsrefstore.go Outdated Show resolved Hide resolved
@whyrusleeping
Copy link
Member

I don't quite think this one is complete, I get these errors when updating to this commit:

why@sirius ~/c/lotus (master)> go get github.com/ipfs/go-filestore@02c92dc77583754cc57f8979c32ed6ef8393cbb8
# github.com/ipfs/go-filestore
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/filestore.go:248:17: not enough arguments in call to f.bs.HashOnRead
	have (bool)
	want (context.Context, bool)
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/filestore.go:251:5: cannot use (*Filestore)(nil) (type *Filestore) as type blockstore.Blockstore in assignment:
	*Filestore does not implement blockstore.Blockstore (wrong type for HashOnRead method)
		have HashOnRead(bool)
		want HashOnRead(context.Context, bool)
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/fsrefstore.go:81:14: undefined: dshelp.DsKeyToCid
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/fsrefstore.go:101:26: undefined: dshelp.CidToDsKey
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/fsrefstore.go:145:26: undefined: dshelp.CidToDsKey
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/fsrefstore.go:259:9: undefined: dshelp.CidToDsKey
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/fsrefstore.go:304:21: undefined: dshelp.CidToDsKey
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/util.go:159:12: undefined: dshelp.DsKeyToCid
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/util.go:164:12: cannot assign error to err in multiple assignment
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/util.go:212:18: undefined: dshelp.DsKeyToCid
../../go/pkg/mod/github.com/ipfs/go-filestore@v0.0.4-0.20211118191525-02c92dc77583/util.go:212:18: too many errors

@aschmahmann
Copy link

aschmahmann commented Nov 19, 2021

@whyrusleeping your PR will live in another castle. This is for the v0 filestore, you will be using the v1 filestore. There will be a duplicate of this PR against the v1 filestore.

Reminder: the v0/v1 filestore business is basically due to go-ipfs not having completed ipfs/kubo#6815 yet (it's the only item scheduled for the v0.12.0 release).

This means repos such as: go-ipfs-blockstore, go-ipfs-ds-help and go-filestore currently have multiple versions (v0 used by go-ipfs, v1 used by hopefully anyone who hasn't been weighed down by needing to migrate their data).

@aschmahmann aschmahmann merged commit a07800a into release-v0 Nov 19, 2021
@aschmahmann aschmahmann deleted the feat/context-v0 branch November 19, 2021 19:01
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants