Revisit Shutdown Behavior #220
Labels
effort/days
Estimated to take multiple days, but less than a week
exp/expert
Having worked on the specific codebase is important
need/maintainer-input
Needs input from the current maintainer(s)
need/triage
Needs initial labeling and prioritization
needs definition
means this story needs further data before it can be estimated
P2
Medium: Good to have, but can wait until someone steps up
We have pretty terrible patterns for shutting down all over the code base.
Currently, you pass a context to Graphsync when you start it and the only way to shutdown is just cancel the context and hope all the go routines get cleaned up (I think they do but...)
Meanwhile, we actually have Shutdown methods for lots of the components but all they do is shut down an internal context... and they're not even exposed publicly.
Per @mvdan :
We should... have a way to shutdown that confirms all the go routines are actually closed.
The text was updated successfully, but these errors were encountered: